Skip to content

Comments

bpo-41371: Handle lzma lib import error in test_zoneinfo.py#21734

Merged
miss-islington merged 1 commit intopython:masterfrom
nmaynes:bpo-41371
Aug 6, 2020
Merged

bpo-41371: Handle lzma lib import error in test_zoneinfo.py#21734
miss-islington merged 1 commit intopython:masterfrom
nmaynes:bpo-41371

Conversation

@nmaynes
Copy link
Contributor

@nmaynes nmaynes commented Aug 4, 2020 •
edited by miss-islington
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Aug 4, 2020
@nmaynes
Copy link
Contributor Author

nmaynes commented Aug 4, 2020

My apologies for the possible deluge of notifications. I messed up the commit history and cleaned it up inefficiently to put it lightly. This should have the approach mentioned by vstinner on issue https://bugs.python.org/issue41476

tirkarthi
tirkarthi approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Note, import_helper is not present in 3.9 and hence automatic backport might fail.

@tirkarthi tirkarthi requested a review from pganssle August 5, 2020 10:36
@nmaynes
Copy link
Contributor Author

nmaynes commented Aug 6, 2020 •
edited by bedevere-bot
Loading

I am happy to do the backport for this PR as long as my understanding is correct. According to the "Accepting Pull Requests" document, once the PR is merged, another PR should be created that backports this fix to 3.9. The backport PR title should be "[3.9] bpo-41371: Handle lzma lib import error in test_zoneinfo.py" Am I understanding the process correctly?

@pganssle
Copy link
Member

pganssle commented Aug 6, 2020

@nmaynes You don't have to worry about the backport, the label is a signal that triggers a bot that does it automatically on merge.

@miss-islington miss-islington merged commit 5f0769a into python:master Aug 6, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Aug 6, 2020

Thanks @nmaynes for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Aug 6, 2020

GH-21758 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 6, 2020
@nmaynes @miss-islington
bpo-41371: Handle lzma lib import error in test_zoneinfo.py (pythonGH…
61a2920 
…-21734)

(cherry picked from commit 5f0769a)

Co-authored-by: Nathan M <nathanmaynes@gmail.com>
@tirkarthi tirkarthi mentioned this pull request Aug 7, 2020
Closed
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Aug 20, 2020
@nmaynes @shihai1991
bpo-41371: Handle lzma lib import error in test_zoneinfo.py (pythonGH…
77b4e68 
…-21734)
tirkarthi pushed a commit to tirkarthi/cpython that referenced this pull request Sep 1, 2020
@nmaynes @tirkarthi
[3.9] bpo-41371: Handle lzma lib import error in test_zoneinfo.py (py…
6ffd614 
…thonGH-21734)

(cherry picked from commit 5f0769a)

Co-authored-by: Nathan M <nathanmaynes@gmail.com>
tirkarthi added a commit that referenced this pull request Oct 10, 2020
@tirkarthi @nmaynes
[3.9] bpo-41371: Handle lzma lib import error in test_zoneinfo.py (GH…
20bdeed 
…-21734) (GH-22039)

(cherry picked from commit 5f0769a)

Co-authored-by: Nathan M <nathanmaynes@gmail.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@nmaynes
bpo-41371: Handle lzma lib import error in test_zoneinfo.py (pythonGH…
e23dbe6 
…-21734)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle pganssle approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

+1 more reviewer

@rougeth rougeth rougeth approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@nmaynes @pganssle @miss-islington @bedevere-bot @rougeth @tirkarthi @the-knights-who-say-ni